Add a note about scoping differences between *x and *x.deref()
#2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
The sections on field access expressions and tuple indexing expressions may also benefit from similar examples or links to that example, since autoderef means they're also affected by this behavior. The autoderef section on the field access expressions page doesn't contradict it, at least. The tuple indexing expressions section doesn't account for autoderef at all, so it will need to be reworked first. |
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
dianne
force-pushed
the
deref-desugar-scoping-difference
branch
from
d8c164b to
ddc1d58
Compare
|
@rustbot ready I'll open a separate PR to add text for |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section on
*operators states that an overloaded*xis equivalent in immutable place expression contexts to*std::ops::Deref::deref(&x)and that it is equivalent in mutable place expression contexts to*std::ops::DerefMut::deref_mut(&mut x). That isn't quite true for their temporary scopes, so this PR adds a note including an example where the difference affects static semantics.